Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10058/12372d7 backport][3.11] Remove unreachable content length check for chunked encoding #10060

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 27, 2024

(cherry picked from commit 12372d7)

@bdraco bdraco changed the title Remove unreachable content length check for chunked encoding (#10058) [PR #10058/12372d7 backport][3.11] Remove unreachable content length check for chunked encoding Nov 27, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 27, 2024
Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #10060 will not alter performance

Comparing patchback/backports/3.11/12372d7fe06d95c1c633a3b8119aecf4e86cf94d/pr-10058 (3fe926f) with 3.11 (7e628f4)

Summary

✅ 44 untouched benchmarks

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (7e628f4) to head (3fe926f).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11   #10060      +/-   ##
==========================================
+ Coverage   97.93%   98.06%   +0.13%     
==========================================
  Files         122      122              
  Lines       36965    36968       +3     
  Branches     4442     4451       +9     
==========================================
+ Hits        36200    36251      +51     
+ Misses        567      540      -27     
+ Partials      198      177      -21     
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (+0.10%) ⬆️
OS-Linux 97.65% <100.00%> (+0.10%) ⬆️
OS-Windows 94.56% <100.00%> (+0.10%) ⬆️
OS-macOS 96.78% <100.00%> (+0.10%) ⬆️
Py-3.10.11 96.62% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.21% <100.00%> (+0.05%) ⬆️
Py-3.11.10 97.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.70% <100.00%> (+0.30%) ⬆️
Py-3.12.7 97.72% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 97.71% <100.00%> (+0.94%) ⬆️
Py-3.9.13 96.55% <100.00%> (?)
Py-3.9.20 97.09% <100.00%> (?)
Py-pypy7.3.16 96.69% <100.00%> (?)
VM-macos 96.78% <100.00%> (+0.10%) ⬆️
VM-ubuntu 97.65% <100.00%> (+0.10%) ⬆️
VM-windows 94.56% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 27, 2024 04:56
@bdraco bdraco requested a review from asvetlov as a code owner November 27, 2024 04:56
@bdraco bdraco enabled auto-merge (squash) November 27, 2024 04:56
@bdraco bdraco merged commit a5a6981 into 3.11 Nov 27, 2024
32 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/12372d7fe06d95c1c633a3b8119aecf4e86cf94d/pr-10058 branch November 27, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant