Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10156/00700458 backport][3.12] Add ALPN extension to client SSL Context #10164

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 12, 2024

This is a backport of PR #10156 as merged into master (0070045).

What do these changes do?

Add "http/1.1" ALPN extension to aiohttp client's SSL Context.

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Fixes #10152

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder

Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #10164 will not alter performance

Comparing patchback/backports/3.12/00700458eb7741f15861a8616dbf77a0d82dc31f/pr-10156 (3e4591f) with 3.12 (5d9d830)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (5d9d830) to head (3e4591f).
Report is 2 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10164   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         123      123           
  Lines       37139    37155   +16     
  Branches     4468     4468           
=======================================
+ Hits        36419    36435   +16     
  Misses        542      542           
  Partials      178      178           
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.65% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.57% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.77% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.62% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.21% <100.00%> (+0.04%) ⬆️
Py-3.11.10 97.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.69% <100.00%> (-0.01%) ⬇️
Py-3.12.7 97.44% <100.00%> (-0.27%) ⬇️
Py-3.12.8 94.36% <100.00%> (?)
Py-3.13.0 96.55% <100.00%> (+<0.01%) ⬆️
Py-3.13.1 97.67% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.55% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.13% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.69% <100.00%> (+<0.01%) ⬆️
VM-macos 96.77% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.65% <100.00%> (+<0.01%) ⬆️
VM-windows 94.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asvetlov asvetlov merged commit 99a3737 into 3.12 Dec 12, 2024
36 checks passed
@asvetlov asvetlov deleted the patchback/backports/3.12/00700458eb7741f15861a8616dbf77a0d82dc31f/pr-10156 branch December 12, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants