Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10093/7b5d54a backport][3.12] Use quote_cookie setting from ClientSession's cookiejar in tmp_cookie_jar #10176

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 17, 2024

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sam Bull git@sambull.org
(cherry picked from commit 7b5d54a)

…kie_jar` (#10093)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sam Bull <git@sambull.org>
(cherry picked from commit 7b5d54a)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 17, 2024
@bdraco bdraco changed the title Use quote_cookie setting from ClientSession's cookiejar in tmp_cookie_jar (#10093) [PR #10093/7b5d54a backport][3.12] Use quote_cookie setting from ClientSession's cookiejar in tmp_cookie_jar Dec 17, 2024
@bdraco bdraco marked this pull request as ready for review December 17, 2024 18:43
Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #10176 will not alter performance

Comparing patchback/backports/3.12/7b5d54a96c1dd1282e9a79f9fc8056c02ca91c6f/pr-10093 (ffb3464) with 3.12 (5afac55)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (5afac55) to head (ffb3464).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10176   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         123      123           
  Lines       37182    37204   +22     
  Branches     4470     4476    +6     
=======================================
+ Hits        36463    36485   +22     
  Misses        542      542           
  Partials      177      177           
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.66% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.58% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.78% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.63% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.21% <100.00%> (?)
Py-3.11.11 97.23% <100.00%> (-0.05%) ⬇️
Py-3.11.9 96.71% <100.00%> (+2.49%) ⬆️
Py-3.12.8 97.73% <100.00%> (+<0.01%) ⬆️
Py-3.13.1 97.71% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.56% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.10% <100.00%> (-0.03%) ⬇️
Py-pypy7.3.16 96.70% <100.00%> (-0.01%) ⬇️
VM-macos 96.78% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.66% <100.00%> (+<0.01%) ⬆️
VM-windows 94.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) December 17, 2024 18:51
@bdraco bdraco merged commit 86e2140 into 3.12 Dec 17, 2024
34 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/7b5d54a96c1dd1282e9a79f9fc8056c02ca91c6f/pr-10093 branch December 17, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants