Show more verbose message on import errors #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix failed tests |
ImportError is not always 'module not found', so we should display
more verbose message when this exception occured.
For example message:
aiohttp.web: error: unable to import defiler.server: No module named 'aiomysql'
is more useful then:
aiohttp.web: error: module 'defiler.server' not found
redixin
force-pushed
the
fix_import_error
branch
from
9528f4a
to
b784521
Compare
Current coverage is 98.51% (diff: 100%)@@ master #1319 diff @@
==========================================
Files 29 29
Lines 6515 6515
Methods 0 0
Messages 0 0
Branches 1094 1094
==========================================
Hits 6418 6418
Misses 47 47
Partials 50 50
|
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show more verbose message on import errors when using
python -m aiohttp.webUser will see more details in case of problems with their code.
For example message:
is more useful then:
such messages can be even misleading