Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support of IDNA in Client #1445

Merged
merged 5 commits into from
Dec 3, 2016
Merged

Conversation

Martiusweb
Copy link
Contributor

@Martiusweb Martiusweb commented Dec 2, 2016

What do these changes do?

Use the IDNA-encoded version of the host in:

  • the Host header of a request,
  • the path of a CONNECT request (this one is untested),
  • CookieJar.update_cookies() and CookieJar.filter_cookies()

Are there changes in behavior for the user?

Users will be able to use unicode hostnames when performing a request, using a proxy or using CookieJar update_cookies() and filter_cookies() methods.

Related issue number

Fixes #1444 and some other places where raw_host should be used.

@codecov-io
Copy link

codecov-io commented Dec 3, 2016

Current coverage is 98.81% (diff: 100%)

Merging #1445 into master will not change coverage

@@             master      #1445   diff @@
==========================================
  Files            30         30          
  Lines          6931       6931          
  Methods           0          0          
  Messages          0          0          
  Branches       1146       1146          
==========================================
  Hits           6849       6849          
  Misses           40         40          
  Partials         42         42          

Powered by Codecov. Last update 718313b...c3d64df

@asvetlov asvetlov merged commit 912d871 into aio-libs:master Dec 3, 2016
@asvetlov
Copy link
Member

asvetlov commented Dec 3, 2016

Thanks!

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent support of IDNA hostnames in Client
3 participants