Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix polls demo run application #1487

Merged
merged 2 commits into from
Dec 18, 2016
Merged

fix polls demo run application #1487

merged 2 commits into from
Dec 18, 2016

Conversation

ediskandarov
Copy link
Contributor

@ediskandarov ediskandarov commented Dec 17, 2016

I'm adding a bug fix, but there's no branch for current version of aiohttp - 1.2. Set master as a target branch.

What do these changes do?

Fixed run demo polls application:

$ python -m aiohttpdemo_polls
Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/e.iskandarov/sandbox/aiohttp/demos/polls/aiohttpdemo_polls/__main__.py", line 3, in <module>
    main()
TypeError: main() missing 1 required positional argument: 'argv'

Checklist

  • [√] I think the code is well written
  • [-] Unit tests for the changes exist
  • [-] Documentation reflects the changes
  • [√] Add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [√] Add a new entry to CHANGES.rst

@codecov-io
Copy link

codecov-io commented Dec 17, 2016

Current coverage is 98.85% (diff: 100%)

Merging #1487 into master will not change coverage

@@             master      #1487   diff @@
==========================================
  Files            30         30          
  Lines          6984       6984          
  Methods           0          0          
  Messages          0          0          
  Branches       1163       1163          
==========================================
  Hits           6904       6904          
  Misses           40         40          
  Partials         40         40          

Powered by Codecov. Last update 4eef48a...34c2d18

@asvetlov asvetlov merged commit 904682c into aio-libs:master Dec 18, 2016
@asvetlov
Copy link
Member

Cool! Thank you.

P.S.
I've created missing 1.2 branch

@ediskandarov ediskandarov deleted the fix-polls-demo branch December 18, 2016 09:13
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants