Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blind readline of multipart epilogue #1581

Merged

Conversation

terencehonles
Copy link
Contributor

@terencehonles terencehonles commented Feb 3, 2017

What do these changes do?

fixes concern mentioned in PR #1532

Are there changes in behavior for the user?

No

Related issue number

No

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@codecov-io
Copy link

codecov-io commented Feb 3, 2017

Codecov Report

Merging #1581 into master will increase coverage by 0.02%.

@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
+ Coverage   98.49%   98.51%   +0.02%     
==========================================
  Files          31       31              
  Lines        7219     7223       +4     
  Branches     1196     1197       +1     
==========================================
+ Hits         7110     7116       +6     
+ Misses         62       61       -1     
+ Partials       47       46       -1
Impacted Files Coverage Δ
aiohttp/multipart.py 93.89% <100%> (+0.37%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247f9bb...da06651. Read the comment docs.

@terencehonles
Copy link
Contributor Author

@kxepal This should probably ease your concerns 😉 , right?

@kxepal
Copy link
Member

kxepal commented Feb 3, 2017

Indeed. Thanks, @terencehonles !

@kxepal kxepal merged commit 5399c25 into aio-libs:master Feb 3, 2017
@terencehonles terencehonles deleted the fix-blind-read-of-multipart-epilogue branch February 3, 2017 19:13
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants