-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ClientSession initialization warning #1586
Conversation
This fixes an issue with ClientSession throwing a warning when feeding an event loop into it when calling it from a normal function. This should help silence annoying warnings for libraries that "lazy" initializes ClientSession and properly closes the session and handles it. Now those libraries would have no need for useless bug reports.
Codecov Report@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
+ Coverage 98.54% 98.54% +<.01%
==========================================
Files 32 32
Lines 7265 7276 +11
Branches 1208 1210 +2
==========================================
+ Hits 7159 7170 +11
Misses 61 61
Partials 45 45
Continue to review full report at Codecov.
|
add extra code just to satisfy tests? -1 |
Not that I'm condoning this PR, but @fafhrd91 the original PR was proposed to be modified: #1468 (comment) |
i think this PR is too much for andrew's comment. |
done |
thanks. |
This fixes an issue with ClientSession throwing a warning when feeding
an event loop into it when calling it from a normal function. This
should help silence annoying warnings for libraries that "lazy"
initializes ClientSession and properly closes the session and handles
it. Now those libraries would have no need for useless bug reports.
What do these changes do?
Fixes the warning when calling a ClientSession instance with an event loop that is passed to the class.
Are there changes in behavior for the user?
None
Related issue number
#1468 (comment)
Checklist
CONTRIBUTORS.txt
CHANGES.rst
#issue_number
format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.