Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also keep blank values in multipart.form() #1788

Merged
merged 1 commit into from
Apr 5, 2017
Merged

also keep blank values in multipart.form() #1788

merged 1 commit into from
Apr 5, 2017

Conversation

iceboy233
Copy link
Member

What do these changes do?

keep blank values in multipart.form()

Are there changes in behavior for the user?

foo=bar&foo=baz&boo=\r\n--:-- will be parsed as [('foo', 'bar'), ('foo', 'baz'), ('boo', '')], instead of [('foo', 'bar'), ('foo', 'baz')]

Related issue number

#1765

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@codecov-io
Copy link

codecov-io commented Apr 5, 2017

Codecov Report

Merging #1788 into 2.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.0    #1788   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files          37       37           
  Lines        7428     7428           
  Branches     1293     1293           
=======================================
  Hits         7188     7188           
  Misses        111      111           
  Partials      129      129
Impacted Files Coverage Δ
aiohttp/multipart.py 95.35% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c889474...7c9aec6. Read the comment docs.

@fafhrd91 fafhrd91 merged commit 4a4bc54 into aio-libs:2.0 Apr 5, 2017
@fafhrd91
Copy link
Member

fafhrd91 commented Apr 5, 2017

thanks

@iceboy233 iceboy233 deleted the also-fix-multipart branch April 5, 2017 23:56
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants