Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1839: python 3.7 regression for regexp escaping #1908

Merged
merged 3 commits into from
May 21, 2017
Merged

Conversation

asvetlov
Copy link
Member

See #1839

@codecov-io
Copy link

codecov-io commented May 21, 2017

Codecov Report

Merging #1908 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
+ Coverage   97.06%   97.06%   +<.01%     
==========================================
  Files          37       37              
  Lines        7560     7561       +1     
  Branches     1314     1314              
==========================================
+ Hits         7338     7339       +1     
  Misses        100      100              
  Partials      122      122
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.41% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee65a4...3041136. Read the comment docs.

@asvetlov asvetlov merged commit e5c7bfe into master May 21, 2017
@asvetlov asvetlov deleted the fix_1839 branch May 21, 2017 09:00
asvetlov pushed a commit that referenced this pull request May 22, 2017
…eme and host resolution (#1881)

* #1134 Support X-Forwarded-* and Forwarded implicitly

* #1134 tests

* added myself to contributors

* added line to changes.rst

* Update CHANGES.rst

* Update CHANGES.rst

* deprecating secure_proxy_ssl_header

* more extensive Forwarded parsing

* flake

* make isort with new parameters

* Fix #1839: python 3.7 regression for regexp escaping (#1908)

* Fix #1839: python 3.7 regression for regexp escaping

* Fix import sort order

* small changes

* unpacking tuple implicit

* #1134 Support X-Forwarded-* and Forwarded implicitly

* #1134 tests

* added myself to contributors

* added line to changes.rst

* deprecating secure_proxy_ssl_header

* more extensive Forwarded parsing

* flake

* small changes

* unpacking tuple implicit

* handling multiple field-values, fixed quoted-pair bug (now using vchar instead of tchar), changed return type of forwarded
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants