Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed consecutive calls for write_eof on Response #1939

Merged
merged 9 commits into from
Jun 19, 2017
Merged

Fixed consecutive calls for write_eof on Response #1939

merged 9 commits into from
Jun 19, 2017

Conversation

kammala
Copy link
Contributor

@kammala kammala commented Jun 1, 2017

What do these changes do?

Fix runtime exception while trying to return Response, which calls write_eof inside view.

Now we can create views which can do some post-processing logic for response(e.g. send some metrics, log some useful info, etc) without affecting response time.

Are there changes in behavior for the user?

No

Related issue number

No

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@codecov-io
Copy link

codecov-io commented Jun 1, 2017

Codecov Report

Merging #1939 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
+ Coverage   97.05%   97.05%   +<.01%     
==========================================
  Files          37       37              
  Lines        7612     7614       +2     
  Branches     1328     1329       +1     
==========================================
+ Hits         7388     7390       +2     
  Misses        101      101              
  Partials      123      123
Impacted Files Coverage Δ
aiohttp/web_response.py 98.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d63d49...72e18ea. Read the comment docs.

@asvetlov
Copy link
Member

asvetlov commented Jun 1, 2017

The PR is good, but
Please add a record to CHANGES.txt
You also might mention yourself in CONTRIBUTORS.txt. It's not required but why not?

@fafhrd91
Copy link
Member

fafhrd91 commented Jun 6, 2017

@asvetlov ping

@asvetlov asvetlov mentioned this pull request Jun 19, 2017
5 tasks
@asvetlov asvetlov merged commit 5562f9a into aio-libs:master Jun 19, 2017
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants