-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed consecutive calls for write_eof on Response #1939
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1939 +/- ##
==========================================
+ Coverage 97.05% 97.05% +<.01%
==========================================
Files 37 37
Lines 7612 7614 +2
Branches 1328 1329 +1
==========================================
+ Hits 7388 7390 +2
Misses 101 101
Partials 123 123
Continue to review full report at Codecov.
|
The PR is good, but |
added records to CHANGES.rst and CONTRIBUTORS.txt
* Add doc for add_head, update doc for add_get. * Update CHANGES
fixed merge conflicts
@asvetlov ping |
Thanks! |
What do these changes do?
Fix runtime exception while trying to return
Response
, which callswrite_eof
inside view.Now we can create views which can do some post-processing logic for response(e.g. send some metrics, log some useful info, etc) without affecting response time.
Are there changes in behavior for the user?
No
Related issue number
No
Checklist
CONTRIBUTORS.txt
CHANGES.rst
#issue_number
format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.