Use functools.wraps when wrapping synchronous handlers #1953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
They change the code that wraps synchronous functions, using functools.wraps to ensure that aspects from the synchronous functions such as
__doc__
are also available on the wrapper.This allows to use aiohttp-swagger with synchronous handlers.
Are there changes in behavior for the user?
When accessed from the app, synchronous route handlers will now include additional metadata that before only asynchronous handlers provided.
Checklist
Documentation reflects the changesIt’s a bug fix which should not affect the documentation.
CONTRIBUTORS.txt
CHANGES.rst
#issue_number
format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.