Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1978: Deprecate on_loop_available #1989

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Fix #1978: Deprecate on_loop_available #1989

merged 1 commit into from
Jun 19, 2017

Conversation

asvetlov
Copy link
Member

Fix for #1978

kxepal
kxepal reviewed Jun 19, 2017
View reviewed changes
CHANGES.rst

-

-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reserved for future needs? (:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reduces the probability of merge conflict.
pytest project used to follow this practice but now they switched to new approach: a folder for change records.
We need the same maybe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thanks.

@asvetlov asvetlov merged commit 0472954 into master Jun 19, 2017
@asvetlov asvetlov deleted the deprecate_on_loop_available branch June 19, 2017 15:21
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kxepal kxepal kxepal left review comments

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvetlov @kxepal