Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X-Forward-For option to Access Log #2123 #2124

Closed
wants to merge 1 commit into from

Conversation

harobed
Copy link

@harobed harobed commented Jul 23, 2017

Add X-Forward-For option to Access Log #2123

@codecov-io
Copy link

codecov-io commented Jul 23, 2017

Codecov Report

Merging #2124 into master will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2124      +/-   ##
==========================================
- Coverage   97.11%   97.06%   -0.06%     
==========================================
  Files          38       38              
  Lines        7694     7699       +5     
  Branches     1346     1347       +1     
==========================================
+ Hits         7472     7473       +1     
- Misses        101      105       +4     
  Partials      121      121
Impacted Files Coverage Δ
aiohttp/helpers.py 96.26% <33.33%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240a0e2...410a361. Read the comment docs.

@asvetlov
Copy link
Member

Should be implemented as suggested in #2123

@asvetlov asvetlov closed this Jul 25, 2017
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants