Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving to async/await syntax #2350

Closed
wants to merge 5 commits into from
Closed

moving to async/await syntax #2350

wants to merge 5 commits into from

Conversation

eteamin
Copy link
Contributor

@eteamin eteamin commented Oct 19, 2017

What do these changes do?

Changed some files to use async/await syntax.

Related issue number

issue #2343

@eteamin eteamin closed this Oct 19, 2017
@asvetlov
Copy link
Member

I suggest not converting everything at once but create a PR per file. Tests should go first, sure.
Reviewing single file is much easier than the whole project.

I'll tune CI bots to disable 3.4 this evening

@samuelcolvin
Copy link
Member

I understand why you say this, but doing a build for each file will take a loooong time and will also impact build times for all other aio-lib projects since travis throttles builds per organisation.

I spent about two hours yesterday waiting for aiohttp builds to finish to aiohttp-devtools builds would start.

@webknjaz
Copy link
Member

@samuelcolvin normal push builds are relatively fast: they don't run OS X at all.

@asvetlov
Copy link
Member

Well, a PR for a 2-3 small files is an option -- but reviewing 10000 long diff is a nightmare.
Pretty sure everybody understands it very well.

@samuelcolvin
Copy link
Member

yes I agree, makes sense.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants