-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving to async/await syntax #2350
Conversation
I suggest not converting everything at once but create a PR per file. Tests should go first, sure. I'll tune CI bots to disable 3.4 this evening |
I understand why you say this, but doing a build for each file will take a loooong time and will also impact build times for all other aio-lib projects since travis throttles builds per organisation. I spent about two hours yesterday waiting for aiohttp builds to finish to aiohttp-devtools builds would start. |
@samuelcolvin normal push builds are relatively fast: they don't run OS X at all. |
Well, a PR for a 2-3 small files is an option -- but reviewing 10000 long diff is a nightmare. |
yes I agree, makes sense. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
Changed some files to use async/await syntax.
Related issue number
issue #2343