Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct charset detection #2493

Merged
merged 4 commits into from
Nov 10, 2017
Merged

Correct charset detection #2493

merged 4 commits into from
Nov 10, 2017

Conversation

argaen
Copy link
Member

@argaen argaen commented Nov 9, 2017 •
edited
Loading

Fix for #2197

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

argaen
argaen commented Nov 9, 2017
View reviewed changes
.gitignore
@@ -45,3 +45,4 @@ virtualenv.py
.develop
.gitconfig
.flake
.python-version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated with MR. This comes from pyenv

argaen
argaen commented Nov 9, 2017
View reviewed changes
tests/test_web_response.py
@@ -887,6 +887,14 @@ def test_ctor_charset_without_text():
assert 'koi8-r' == resp.charset


def test_ctor_content_type_with_extra():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what does ctor stand for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constructor

@codecov-io
Copy link

codecov-io commented Nov 9, 2017 •
edited
Loading

Codecov Report

Merging #2493 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2493   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          39       39           
  Lines        8098     8098           
  Branches     1416     1416           
=======================================
  Hits         7867     7867           
  Misses         99       99           
  Partials      132      132
Impacted Files Coverage Δ
aiohttp/web_response.py 98.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73213b7...81fe7ee. Read the comment docs.

@asvetlov asvetlov merged commit c578c03 into aio-libs:master Nov 10, 2017
@asvetlov
Copy link
Member

thanks

asvetlov pushed a commit that referenced this pull request Nov 10, 2017
@argaen @asvetlov
Correct charset detection (#2493)
aa77a47 
* Content-type parsed correctly in Response

* Add .python-version to gitignore

* Add changes
@asvetlov asvetlov mentioned this pull request Feb 9, 2018
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fafhrd91 fafhrd91 fafhrd91 left review comments

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@argaen @codecov-io @asvetlov @fafhrd91