Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop user supplied loop #2531

Merged
merged 6 commits into from
Nov 18, 2017
Merged

Drop user supplied loop #2531

merged 6 commits into from
Nov 18, 2017

Conversation

asvetlov
Copy link
Member

For sake of #2530

The mode is exists for not closing the loop for sake of later reusage, I believe we can invite more robust way by #2530

@kxepal
Copy link
Member

kxepal commented Nov 18, 2017

So now we always use asyncio global loop and if I want/need to run an app in different one, I should run it in different thread?

@codecov-io
Copy link

codecov-io commented Nov 18, 2017

Codecov Report

Merging #2531 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2531      +/-   ##
==========================================
- Coverage   97.13%   97.13%   -0.01%     
==========================================
  Files          39       39              
  Lines        8070     8059      -11     
  Branches     1415     1411       -4     
==========================================
- Hits         7839     7828      -11     
  Misses         99       99              
  Partials      132      132
Impacted Files Coverage Δ
aiohttp/web.py 98.92% <75%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c4621...075decb. Read the comment docs.

@asvetlov
Copy link
Member Author

Running two loops in parallel in the same thread is impossible, isn't it?
The program should run one loop per thread (except unittest case), most likely the single loop in main thread per process.

@asvetlov asvetlov merged commit ad8f45f into master Nov 18, 2017
@asvetlov asvetlov deleted the drop-user-supplied-loop branch November 18, 2017 12:20
@donkahuna
Copy link

If I want to change the loop, for example use uvloop ? How can I do this ?

@asvetlov
Copy link
Member Author

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants