Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop access to TCP tuning options outside of the stream scope #2612

Merged
merged 3 commits into from
Dec 18, 2017

Conversation

pfreixes
Copy link
Contributor

What do these changes do?

Before this commit, the TCP tunning was allowed from PayloadWriter
and Response classes, this was exclusively used by just some edge cases and
caused some overhead in performance and maintainability.

Since now, the TCP tunning has to be done using the stream and its
the responsibility of the developer set and set back the proper values.

Are there changes in behavior for the user?

No

Related issue number

#2604

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Before this commit, the TCP tunning wasallowed from PayloadWriter
and Response classes, this was exclusive used by just some edge cases and
caused some overhead in performance and maintainability.

Since now, the TCP tunning has to be done using the stream and its
responsibility of the developer set and set back the proper values.
@pfreixes pfreixes requested review from fafhrd91 and removed request for fafhrd91 December 16, 2017 16:49
@codecov-io
Copy link

codecov-io commented Dec 16, 2017

Codecov Report

Merging #2612 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2612      +/-   ##
=========================================
+ Coverage   97.88%   97.9%   +0.01%     
=========================================
  Files          38      38              
  Lines        7344    7314      -30     
  Branches     1270    1270              
=========================================
- Hits         7189    7161      -28     
+ Misses         51      49       -2     
  Partials      104     104
Impacted Files Coverage Δ
aiohttp/web_response.py 98.18% <ø> (-0.08%) ⬇️
aiohttp/http_writer.py 99.42% <ø> (+1.07%) ⬆️
aiohttp/web_protocol.py 89.42% <100%> (-0.11%) ⬇️
aiohttp/web_fileresponse.py 97.88% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c178a99...a84cb75. Read the comment docs.

Copy link
Member

@fafhrd91 fafhrd91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

This change is fine. Though, other developers should check this. As I remember @socketpair originally proposed support for nodelay and cork

@asvetlov
Copy link
Member

@pfreixes please merge

@pfreixes pfreixes merged commit 486eaf2 into master Dec 18, 2017
@asvetlov asvetlov deleted the dont_supoport_tcp_tunning_payload branch January 11, 2018 20:26
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants