-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop access to TCP tuning options outside of the stream scope #2612
Conversation
Before this commit, the TCP tunning wasallowed from PayloadWriter and Response classes, this was exclusive used by just some edge cases and caused some overhead in performance and maintainability. Since now, the TCP tunning has to be done using the stream and its responsibility of the developer set and set back the proper values.
Codecov Report
@@ Coverage Diff @@
## master #2612 +/- ##
=========================================
+ Coverage 97.88% 97.9% +0.01%
=========================================
Files 38 38
Lines 7344 7314 -30
Branches 1270 1270
=========================================
- Hits 7189 7161 -28
+ Misses 51 49 -2
Partials 104 104
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
This change is fine. Though, other developers should check this. As I remember @socketpair originally proposed support for nodelay and cork
@pfreixes please merge |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
Before this commit, the TCP tunning was allowed from PayloadWriter
and Response classes, this was exclusively used by just some edge cases and
caused some overhead in performance and maintainability.
Since now, the TCP tunning has to be done using the stream and its
the responsibility of the developer set and set back the proper values.
Are there changes in behavior for the user?
No
Related issue number
#2604
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.