Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web.run_app support access_log_class param #2616

Merged
merged 7 commits into from
Dec 21, 2017
Merged

web.run_app support access_log_class param #2616

merged 7 commits into from
Dec 21, 2017

Conversation

codeif
Copy link
Contributor

@codeif codeif commented Dec 19, 2017

Function web.run_app add param access_log_class

Are there changes in behavior for the user?

None

Related issue number

#2615

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

asvetlov
asvetlov requested changes Dec 20, 2017
View reviewed changes
docs/web_reference.rst
@@ -2330,6 +2331,10 @@ Utilities
system will allow before refusing new
connections (``128`` by default).

:param access_log_class: class for `access_logger`. Default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following lines after the last :param: item

.. versionadded:: 3.0

   Support *access_log_class* parameter.

@asvetlov
Copy link
Member

Also please run make isort before committing.

@codeif
Copy link
Contributor Author

codeif commented Dec 21, 2017 •
edited
Loading

Thanks @asvetlov . I have commited as your suggested.

@codecov-io
Copy link

codecov-io commented Dec 21, 2017 •
edited
Loading

Codecov Report

Merging #2616 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2616   +/-   ##
======================================
  Coverage    97.9%   97.9%           
======================================
  Files          38      38           
  Lines        7317    7317           
  Branches     1271    1271           
======================================
  Hits         7164    7164           
  Misses         49      49           
  Partials      104     104
Impacted Files Coverage Δ
aiohttp/web.py 98.76% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b9373...759d0fb. Read the comment docs.

asvetlov
asvetlov approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@asvetlov asvetlov merged commit 19c138c into aio-libs:master Dec 21, 2017
@asvetlov
Copy link
Member

Thanks!

@asvetlov asvetlov mentioned this pull request Dec 21, 2017
Closed
@codeif codeif deleted the custom-access-logger branch December 21, 2017 06:17
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codeif @asvetlov @codecov-io @tqlyyds