Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging enhancements and fixes #2642

Closed
wants to merge 3 commits into from

Conversation

thehesiod
Copy link
Contributor

@thehesiod thehesiod commented Jan 6, 2018

What do these changes do?

fix a few log related issues

Are there changes in behavior for the user?

If user had inherited from AccessLogger and replaced the "log" function without using *args their calls may fail

Related issue number

#2641

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@thehesiod thehesiod changed the title work on https://github.com/aio-libs/aiohttp/issues/2641 logging enhancements and fixes Jan 6, 2018
@asvetlov
Copy link
Member

asvetlov commented Feb 9, 2018

I've applied 4c2ff2c to fix the problem in backward compatible way.

@asvetlov asvetlov closed this Feb 9, 2018
@thehesiod thehesiod deleted the thehesiod/log-fix branch June 1, 2018 23:30
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants