added _reuse_address and _reuse_port to web_runner.TCPSite.__slots__

[jancespivo]

Hi,
_reuse_address and _reuse_port are not included in TCPSite.__slots__

import aiohttp.web
app = aiohttp.web.Application()
aiohttp.web.run_app(app)

Invokes:
AttributeError: 'TCPSite' object has no attribute '_reuse_address'

Best regards

[codecov-io]

Codecov Report

Merging #2792 into master will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
+ Coverage   97.83%   97.99%   +0.16%     
==========================================
  Files          39       39              
  Lines        7379     7379              
  Branches     1296     1296              
==========================================
+ Hits         7219     7231      +12     
+ Misses         53       47       -6     
+ Partials      107      101       -6

Impacted Files	Coverage Δ
aiohttp/web_runner.py	100% <100%> (ø)	⬆️
aiohttp/web_urldispatcher.py	99.19% <0%> (+0.32%)	⬆️
aiohttp/client_reqrep.py	97.44% <0%> (+0.36%)	⬆️
aiohttp/helpers.py	97.29% <0%> (+0.49%)	⬆️
aiohttp/connector.py	96.82% <0%> (+0.74%)	⬆️
aiohttp/payload.py	98.74% <0%> (+1.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572aeb6...f0cb03f. Read the comment docs.

[asvetlov]

Hmm. This is a bug definitely but I wonder why tests are passed without slots.
Your code snipped didn't raise an error too.

[drpoggi]

I believe this error only happens on 3.7 where now ABC defines a __slots__

[asvetlov]

You are right. This explains everything.

[jancespivo]

Yes, sorry. It was actually python 3.8.0a0 I forgot change the venv 🤦‍♂️
I am a little suprised the using of __slots__ is useless for class inherited from ABC in python < 3.7

[drpoggi]

It's not useless, it just requires subclasses to be explicit.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new