-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client DNS start/end events not fired #2841
Comments
That's sad but the fix looks easy. |
yes |
shame of me, the integration test that wires all of the tracing does not cover this signal [1] ... if its not a big deal would be nice if we can add these signals to that test. That would help in the future to avoid the same mistake. [1] https://github.com/aio-libs/aiohttp/blob/master/tests/test_web_functional.py#L1641 |
Thanks for pointing the test. I actually wrote a different one and seems like in a wrong place. Will do there. |
Well this just checks the happy path an upper level, if you have others at function level please commit them as well! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
Long story short
Unable to track dns timing via TraceConfig using client with TcpConnector, since
None
intead oftraces
arg passed to direct and proxy connections methodsExpected behaviour
working DNS tracing with TCP
Actual behaviour
dns events missed
Your environment
aiohttp: 3.0.9
OS X
The text was updated successfully, but these errors were encountered: