-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do fire DNS tracing events #2858
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2858 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 39 39
Lines 7444 7444
Branches 1307 1307
=======================================
Hits 7293 7293
Misses 48 48
Partials 103 103
Continue to review full report at Codecov.
|
|
||
await client.get('/redirector', data="foo") | ||
await client.get('http://example.com/redirector', data="foo") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a f"localhost:{server.port}/redirector"
does not fire a DNS event? If it does we wouldn't need it the FakeResolver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolver doesn't perform DNS lookup for IP addresses, only for domain names.
localhost
should be sufficient but unfortunately there are too many boxes with declared but actually disabled IPv6 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I don't get the following sentence.
there are too many boxes with declared but actually disabled IPv6 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont want to block the PR just for a test that in any case can be at any moment refactorized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll try to describe. Some broken environments (Travis-CI included IIRC) resolves localhost
to both 127.0.0.1
and ::1
but IPv6 stack is disabled.
By this communication over IPv6 ::1
fails.
That's why aiohttp.test_utils
and aiohttp test suite use IPv4 127.0.0.1
explicitly.
The situation could be improved I hope but working on it is definitely out if the issue scope.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
Fix for #2841