Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call on_chunk_sent when write_eof is called with a valid chunk #2911

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

pfreixes
Copy link
Contributor

@pfreixes pfreixes commented Apr 4, 2018

What do these changes do?

Fixes a bug with on_chunk_sent signal that must be triggered when write_eof is called using a valid chunk.

Related issue number

#2909

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Apr 4, 2018

Codecov Report

Merging #2911 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2911      +/-   ##
==========================================
+ Coverage   97.98%   97.98%   +<.01%     
==========================================
  Files          40       40              
  Lines        7506     7508       +2     
  Branches     1316     1317       +1     
==========================================
+ Hits         7355     7357       +2     
  Misses         48       48              
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/http_writer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2584ba2...2e372cd. Read the comment docs.

@asvetlov
Copy link
Member

asvetlov commented Apr 4, 2018

Please merge.
Would you [backport] the PR to 3.1 branch?

@pfreixes
Copy link
Contributor Author

pfreixes commented Apr 4, 2018

Yes, I will make the backport.

@pfreixes pfreixes merged commit 6a6ab7d into master Apr 4, 2018
pfreixes added a commit that referenced this pull request Apr 4, 2018
…H-2911)

(cherry picked from commit 6a6ab7d)

Co-authored-by: Pau Freixes <pfreixes@gmail.com>
pfreixes added a commit that referenced this pull request Apr 5, 2018
pfreixes added a commit that referenced this pull request Apr 5, 2018
* Call on_chunk_sent when write_eof is called with a valid chunk (#2911)

(cherry picked from commit 6a6ab7d)

* Amends 4ce3c4a sending the chunk signal by write_eof equal than write (#2913)

(cherry picked from commit c5d3999)
@asvetlov asvetlov deleted the 2909_call_on_chunk_sent_write_eof branch September 7, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants