Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] fix resolve cancellation (#2910) #2931

Merged
merged 1 commit into from
Apr 12, 2018
Merged

[3.1] fix resolve cancellation (#2910) #2931

merged 1 commit into from
Apr 12, 2018

Conversation

asvetlov
Copy link
Member

(cherry picked from commit a7bbaad)

Co-authored-by: Alexander Mohr thehesiod@users.noreply.github.com

* fix resolve cancellation

* fixes based on review

* changes based on review

* add changes file

* rename
(cherry picked from commit a7bbaad)

Co-authored-by: Alexander Mohr <thehesiod@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #2931 into 3.1 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              3.1    #2931   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          39       39           
  Lines        7504     7504           
  Branches     1318     1318           
=======================================
  Hits         7353     7353           
  Misses         48       48           
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/connector.py 96.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2dbcb...376cbbd. Read the comment docs.

@asvetlov asvetlov merged commit 68940b9 into 3.1 Apr 12, 2018
@asvetlov asvetlov deleted the backport-a7bbaad-3.1 branch April 12, 2018 13:14
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants