Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly compare request objects #3125

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Correctly compare request objects #3125

merged 1 commit into from
Jul 9, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jul 9, 2018

Fix #3116

@codecov-io
Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #3125 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
+ Coverage   98.06%   98.06%   +<.01%     
==========================================
  Files          43       43              
  Lines        7837     7839       +2     
  Branches     1354     1354              
==========================================
+ Hits         7685     7687       +2     
  Misses         56       56              
  Partials       96       96
Impacted Files Coverage Δ
aiohttp/web_request.py 98.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbc255...d0dbb06. Read the comment docs.

@asvetlov asvetlov merged commit 19e9fd6 into master Jul 9, 2018
@asvetlov asvetlov deleted the req-cmp branch July 9, 2018 08:27
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Every request object is equal
2 participants