-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vendored http-parser to v 77310ee commit #3209
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3209 +/- ##
==========================================
- Coverage 98.11% 98.07% -0.04%
==========================================
Files 43 43
Lines 7853 7853
Branches 1354 1354
==========================================
- Hits 7705 7702 -3
- Misses 57 59 +2
- Partials 91 92 +1
Continue to review full report at Codecov.
|
@webknjaz I doubt if we should bump to not-released-yet versions of |
Fair enough. But it has some fixes, which may be related to #3208 |
Which commit from http-parser unreleased master fixes #3208 ? |
It seems to be nodejs/http-parser@a7c2e86 from history, but needs verification. |
Well. Let's keep the PR but avoid bumps to unreleased versions in the future. |
Got it |
FTR sticking to tags didn't save us from pulling their bugs :) |
Can confirm that doing this fixed #3208 |
Ok, thank you |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
No description provided.