Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vendored http-parser to v 77310ee commit #3209

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

webknjaz
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #3209 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3209      +/-   ##
==========================================
- Coverage   98.11%   98.07%   -0.04%     
==========================================
  Files          43       43              
  Lines        7853     7853              
  Branches     1354     1354              
==========================================
- Hits         7705     7702       -3     
- Misses         57       59       +2     
- Partials       91       92       +1
Impacted Files Coverage Δ
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.47% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0af887...147f4a8. Read the comment docs.

@webknjaz webknjaz merged commit 6f3766e into master Aug 23, 2018
@asvetlov
Copy link
Member

@webknjaz I doubt if we should bump to not-released-yet versions of http-parser.
According to their log the last is 2.8.1: https://github.com/nodejs/http-parser/releases/tag/v2.8.1

@webknjaz
Copy link
Member Author

Fair enough. But it has some fixes, which may be related to #3208

@asvetlov
Copy link
Member

Which commit from http-parser unreleased master fixes #3208 ?

@webknjaz
Copy link
Member Author

It seems to be nodejs/http-parser@a7c2e86 from history, but needs verification.

@asvetlov
Copy link
Member

Well. Let's keep the PR but avoid bumps to unreleased versions in the future.

@asvetlov asvetlov deleted the feature/upgrade-http-parser-77310ee branch August 24, 2018 14:16
@webknjaz
Copy link
Member Author

Got it

@webknjaz
Copy link
Member Author

FTR sticking to tags didn't save us from pulling their bugs :)

@Swamp-Ig
Copy link

Can confirm that doing this fixed #3208

@asvetlov
Copy link
Member

Ok, thank you

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants