support keep-alive for http 1.0 #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HTTP protocols less than 1.0 (read 0.9) don't support keep alives at all, only 1.0 does. |
|
i do not think 0.9 is the problem at all :) |
| @@ -555,7 +550,13 @@ def enable_chunked_encoding(self): | |||
|
|
|||
| def keep_alive(self): | |||
| if self.keepalive is None: | |||
| return not self.closing | |||
| if self.version <= HttpVersion10: | |||
| if self.headers.get('Connection') == 'keep-alive': | |||
|
Sure, 0.9 is very rare now but disabling keepalive for protocol versions < On Tue, Apr 14, 2015 at 10:49 AM, Nikolay Kim notifications@github.com
Thanks, |
|
sorry, reopened as #325 since I was pulling from the wrong branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keep alive is on by default for http 1.1 and off
by default for http 1.0. parse connection headers
for 1.0 and obey