-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize_path_middleware
should keep the query string.
#3278
Conversation
Nice catch! Could you please reorder imports using isort? https://travis-ci.com/aio-libs/aiohttp/jobs/146631131#L742 |
Codecov Report
@@ Coverage Diff @@
## master #3278 +/- ##
==========================================
- Coverage 98.03% 97.99% -0.04%
==========================================
Files 43 43
Lines 7894 7894
Branches 1354 1354
==========================================
- Hits 7739 7736 -3
- Misses 63 65 +2
- Partials 92 93 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, now it's @asvetlov's turn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks! |
Me needs this fix. The last aiohttp release happened on Sep 5. This fix just barely missed it. |
See #3384 for the next release updates |
normalize_path_middleware
should keep the query string.first commit reveals the bug.
the query string should the same, after transforming by the middleware.
second commit for bugfix
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.