Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for #3515 #3517

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Add test for #3515 #3517

merged 1 commit into from
Jan 14, 2019

Conversation

mihajenko
Copy link
Contributor

@mihajenko mihajenko commented Jan 10, 2019

Add test for #3515 (Send custom per-request cookies even if session jar is empty)

What do these changes do?

Adds a test for #3515 bug fix

Are there changes in behavior for the user?

Test suite is updated.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@mihajenko mihajenko requested a review from asvetlov as a code owner January 10, 2019 13:15
@mihajenko mihajenko changed the title WIP: Add test for #3515 Add test for #3515 Jan 10, 2019
@codecov-io
Copy link

codecov-io commented Jan 13, 2019

Codecov Report

Merging #3517 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3517      +/-   ##
==========================================
- Coverage   97.94%   97.92%   -0.03%     
==========================================
  Files          44       44              
  Lines        8562     8562              
  Branches     1381     1381              
==========================================
- Hits         8386     8384       -2     
- Misses         71       72       +1     
- Partials      105      106       +1
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 96.55% <0%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8aa12...1016f55. Read the comment docs.

tests/test_client_session.py Outdated Show resolved Hide resolved
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@asvetlov asvetlov merged commit aa5cccb into aio-libs:master Jan 14, 2019
@asvetlov
Copy link
Member

Thanks!

asvetlov pushed a commit that referenced this pull request Jan 14, 2019
(cherry picked from commit aa5cccb)

Co-authored-by: Miha Jenko <mjenko@t-2.net>
asvetlov added a commit that referenced this pull request Jan 14, 2019
(cherry picked from commit aa5cccb)

Co-authored-by: Miha Jenko <mjenko@t-2.net>
@lock
Copy link

lock bot commented Jan 14, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants