-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backport of redirect URL fix to 3.5 #3615
Conversation
Thanks! Let's merge this once CI is green. |
@webknjaz It looks like the CI config on 3.5 branch does not pin |
Codecov Report
@@ Coverage Diff @@
## 3.5 #3615 +/- ##
======================================
Coverage ? 97.92%
======================================
Files ? 44
Lines ? 8566
Branches ? 1382
======================================
Hits ? 8388
Misses ? 72
Partials ? 106
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 3.5 #3615 +/- ##
======================================
Coverage ? 97.92%
======================================
Files ? 44
Lines ? 8566
Branches ? 1382
======================================
Hits ? 8388
Misses ? 72
Partials ? 106
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webknjaz OK, removed the commit pinning |
Fix issues after #3614 (backport of #3613 to 3.5).
_HTTPMove.location
is again thelocation
parameter unchanged, no longer unconditionally converted toURL
(which broke a test and might be seen as breaking by the users).