Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backport of redirect URL fix to 3.5 #3615

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fix backport of redirect URL fix to 3.5 #3615

merged 1 commit into from
Feb 18, 2019

Conversation

m-burst
Copy link
Contributor

@m-burst m-burst commented Feb 17, 2019

Fix issues after #3614 (backport of #3613 to 3.5).

_HTTPMove.location is again the location parameter unchanged, no longer unconditionally converted to URL (which broke a test and might be seen as breaking by the users).

@webknjaz
Copy link
Member

Thanks! Let's merge this once CI is green.

@m-burst
Copy link
Contributor Author

m-burst commented Feb 17, 2019

@webknjaz It looks like the CI config on 3.5 branch does not pin pip version to <19.0 so the builds fail :(

@m-burst m-burst requested a review from webknjaz as a code owner February 17, 2019 23:20
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (3.5@74e3d74). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.5    #3615   +/-   ##
======================================
  Coverage       ?   97.92%           
======================================
  Files          ?       44           
  Lines          ?     8566           
  Branches       ?     1382           
======================================
  Hits           ?     8388           
  Misses         ?       72           
  Partials       ?      106
Impacted Files Coverage Δ
aiohttp/web_exceptions.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e3d74...7665f8c. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (3.5@74e3d74). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.5    #3615   +/-   ##
======================================
  Coverage       ?   97.92%           
======================================
  Files          ?       44           
  Lines          ?     8566           
  Branches       ?     1382           
======================================
  Hits           ?     8388           
  Misses         ?       72           
  Partials       ?      106
Impacted Files Coverage Δ
aiohttp/web_exceptions.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e3d74...7665f8c. Read the comment docs.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-burst you shouldn't pin pip. The bug related to it is tracked @ #3581. Please do not mix-in unrelated changes in PRs.

@m-burst
Copy link
Contributor Author

m-burst commented Feb 18, 2019

@webknjaz OK, removed the commit pinning pip.
CI was green with it though, which means that the code changes are probably good to merge.

@webknjaz webknjaz merged commit 79a7213 into aio-libs:3.5 Feb 18, 2019
@lock lock bot added the outdated label Feb 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants