Do print argument optional on run_app function

[dutradda]

What do these changes do?

Do print argument optional on run_app function

Are there changes in behavior for the user?

No

Related issue number

No

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[webknjaz]

Why?

[dutradda]

Why?

@webknjaz

I think it is optional because this line checks if the print argument is valid:

aiohttp/aiohttp/web.py

Line 343 in 7f9be1c

if print: # pragma: no branch

So I can pass a None on the print argument and the aiohttp will not show the start message.

run_app(app, print=None)  # type: ignore

I did this PR because I don't want to put the '#type: ignore" on my code to mypy runs successfully.

[webknjaz]

Alright, the best practice is to explain motivation when creating PRs. Most of the time it's not obvious.

[codecov-io]

Codecov Report

Merging #3690 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3690   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          43       43           
  Lines        8559     8559           
  Branches     1377     1377           
=======================================
  Hits         8378     8378           
  Misses         75       75           
  Partials      106      106

Impacted Files	Coverage Δ
aiohttp/web.py	99.1% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc49f97...7f9be1c. Read the comment docs.

[patchback]

Backport to 3.9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply baddbfe on top of patchback/backports/3.9/baddbfe182a5731d5963438f317cbcce4c094f39/pr-3690

Backporting merged PR #3690 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.9/baddbfe182a5731d5963438f317cbcce4c094f39/pr-3690 upstream/3.9

4. Now, cherry-pick PR Do print argument optional on run_app function #3690 contents into that branch:

   $ git cherry-pick -x baddbfe182a5731d5963438f317cbcce4c094f39

   If it'll yell at you with something like fatal: Commit baddbfe182a5731d5963438f317cbcce4c094f39 is a merge but no -m option was given., add -m 1 as follows intead:

   $ git cherry-pick -m1 -x baddbfe182a5731d5963438f317cbcce4c094f39

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Do print argument optional on run_app function #3690 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.9/baddbfe182a5731d5963438f317cbcce4c094f39/pr-3690

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.