fix typing on set_cookie

[FlorianLudwig]

What do these changes do?

Change type hints on set_cookie to match the existing documentation

Are there changes in behavior for the user?

For users that use linting, yes.

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[codecov-io]

Codecov Report

Merging #3836 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3836      +/-   ##
==========================================
- Coverage   97.96%   97.95%   -0.01%     
==========================================
  Files          43       43              
  Lines        8584    11430    +2846     
  Branches     1372     2256     +884     
==========================================
+ Hits         8409    11196    +2787     
- Misses         71      135      +64     
+ Partials      104       99       -5

Impacted Files	Coverage Δ
aiohttp/web_response.py	98.65% <100%> (+0.92%)	⬆️
aiohttp/worker.py	73.5% <0%> (-24.04%)	⬇️
aiohttp/resolver.py	86.9% <0%> (-13.1%)	⬇️
aiohttp/__init__.py	98.98% <0%> (-1.02%)	⬇️
aiohttp/web_runner.py	96.96% <0%> (-0.96%)	⬇️
aiohttp/client_proto.py	96% <0%> (-0.56%)	⬇️
aiohttp/test_utils.py	99.54% <0%> (-0.15%)	⬇️
aiohttp/http_parser.py	97.82% <0%> (-0.11%)	⬇️
aiohttp/web_exceptions.py	100% <0%> (ø)	⬆️
aiohttp/web_middlewares.py	100% <0%> (ø)	⬆️
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80fec6...6afef0f. Read the comment docs.

[asvetlov]

Please fix CI, mypy linter is failed

[FlorianLudwig]

in my humble opinion that is a bug in typeshed and opened it there: python/typeshed#3059

[asvetlov]

Thank you for the PR.
I think we should wait for upstream fix first

[FlorianLudwig]

The upstream bug is fixed in MyPy 0.720 as it pulls in typeched f5c107cacd7c17ef541278bf228ca411fdeaa11b

[webknjaz]

@FlorianLudwig the checks should pass before merging.

[FlorianLudwig]

@webknjaz Bumping mypy to 0.720 is needed - which results in other new linting errors (see travis).

I can check those later, maybe over the weekend

[asvetlov]

I can check those later, maybe over the weekend

Please do

[serhiy-storchaka]

What about secure?

[serhiy-storchaka]

Is version really a boolean?

[asvetlov]

@FlorianLudwig would you sync the PR with the latest master?
It uses mypy 0.740 now.

[serhiy-storchaka]

And, if the current tests are passed with updated MyPy, would be nice to add tests for set_cookie() with these parameters.

[asvetlov]

The problem is fixed by e4573f8 and 1220613