Allow caller to control HTTP status when using FileResponse #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #4107 +/- ##
==========================================
- Coverage 97.86% 97.81% -0.05%
==========================================
Files 43 43
Lines 8807 8807
Branches 1378 1378
==========================================
- Hits 8619 8615 -4
- Misses 75 78 +3
- Partials 113 114 +1
Continue to review full report at Codecov.
|
asvetlov
requested changes
Sep 27, 2019
CONTRIBUTORS.txt
Outdated
| @@ -275,3 +275,4 @@ Yury Selivanov | |||
| Yusuke Tsutsumi | |||
| Марк Коренберг | |||
| Семён Марьясин | |||
| Ben Timby | |||
There was a problem hiding this comment.
The file is supposed to keep alphabetical order.
Please move this line to appropriate place (or just run sort CONTRIBUTORS.txt -o CONTRIBUTORS.txt).
|
@btimby pro tip: avoid using master branch in your fork, it'll create you a lot of problems. better create a new branch before starting each PR. |
asvetlov
approved these changes
Sep 27, 2019
|
thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Sep 27, 2019
) (cherry picked from commit c422ff3) Co-authored-by: Ben Timby <btimby@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Allow caller to control HTTP status when using
FileResponseAre there changes in behavior for the user?
None
Related issue number
#4106
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.