Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#461: Don't forget to pass data argument forward #462

Closed
wants to merge 1 commit into from
Closed

#461: Don't forget to pass data argument forward #462

wants to merge 1 commit into from

Conversation

kxepal
Copy link
Member

@kxepal kxepal commented Aug 11, 2015

No description provided.

@kxepal
Copy link
Member Author

kxepal commented Aug 11, 2015

Not sure if there is need to duplicate signatures from ClientSession there, so open for comments.

@asvetlov
Copy link
Member

I'm ok with just dropping data parameter.

Ideally it would be cool to have full signatures in our shortcuts.
I don't afraid code duplication but we need tests that make sure signatures are match.

@asvetlov
Copy link
Member

I've merged it into 0.17 branch, I believe we should publish buxfix release with the change.

@asvetlov asvetlov closed this Aug 11, 2015
@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kxepal @asvetlov