Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #476: Raise RuntimeError when chunked enabled and HTTP is 1.0 #488

Merged
merged 2 commits into from
Sep 4, 2015
Merged

Fix #476: Raise RuntimeError when chunked enabled and HTTP is 1.0 #488

merged 2 commits into from
Sep 4, 2015

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Sep 2, 2015

Fix for #476

@asvetlov
Copy link
Member Author

asvetlov commented Sep 2, 2015

Hmm, perhaps we should disable compression for HTTP/1.1 also.

@asvetlov asvetlov added this to the 0.18 milestone Sep 2, 2015
@vbraun
Copy link

vbraun commented Sep 3, 2015

It would be nice if the documentation for enable_chunked_encoding() would mention that, and that you don't need it if content_length is set.

@fafhrd91
Copy link
Member

fafhrd91 commented Sep 3, 2015

i think RuntimeException is fine for chunking and compression.

@asvetlov
Copy link
Member Author

asvetlov commented Sep 3, 2015

Updated docs. @vbraun is it clear for you now?

@vbraun
Copy link

vbraun commented Sep 4, 2015

Thats great, thank you for the help!

asvetlov added a commit that referenced this pull request Sep 4, 2015
@asvetlov
Merge pull request #488 from KeepSafe/forbid_chunked_on_http10
9175145 
Fix #476: Raise RuntimeError when chunked enabled and HTTP is 1.0
@asvetlov asvetlov merged commit 9175145 into master Sep 4, 2015
@asvetlov asvetlov deleted the forbid_chunked_on_http10 branch October 20, 2015 16:40
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.
3 participants
@asvetlov @vbraun @fafhrd91