Set websocket writer compression to Z_BEST_SPEED #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
The performance overhead of using the defaults was noticeable with many connections. This change matches Nginx default.
bdraco
force-pushed
the
websocket_compress_overhead
branch
from
2a85f71
to
413c02a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4993 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 43 43
Lines 8933 8933
Branches 1406 1406
=======================================
Hits 8720 8720
Misses 95 95
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Not sure if docs should be updated as the compression level isn't currently documented. |
|
If this is acceptable, I'll make a backport PR to 3.6 as well |
patchback bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
The performance overhead of using the defaults was noticeable with many connections. This change matches Nginx default. Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> (cherry picked from commit b66b36a)
5 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
The performance overhead of using the defaults was noticeable with many connections. This change matches Nginx default. Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
💚 Backport successfulThe PR was backported to the following branches:
|
asvetlov
pushed a commit
that referenced
this pull request
Oct 15, 2020
The performance overhead of using the defaults was noticeable with many connections. This change matches Nginx default. Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> (cherry picked from commit b66b36a) Co-authored-by: J. Nick Koston <nick@koston.org>
|
@bdraco sorry, the time window for aiohttp 3.6 is closed. |
asvetlov
added a commit
that referenced
this pull request
Oct 16, 2020
The performance overhead of using the defaults was noticeable with many connections. This change matches Nginx default. Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The performance overhead of using the defaults was
noticeable with many connections. This change
matches Nginx default.
Are there changes in behavior for the user?
This is a noticeable performance gain with many connections
and large message sizes. Compressed sizes will be slightly
smaller as described #2856 (comment)
Related issue number
#2856 (comment)
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.