Skip auto-generation of Content-Type header. #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content-Type header automatic generation did not honor the documented `skip_auto_headers` param. With this patch we correctly skip generation of this header while documenting that it is not possible to do so for the `Content-Length` header. See Issue aio-libs#379 for details.
| @@ -290,7 +291,8 @@ def update_body_from_data(self, data): | |||
| if not self.chunked and isinstance(data, io.BytesIO): | |||
| # Not chunking if content-length can be determined | |||
| size = len(data.getbuffer()) | |||
| self.headers[hdrs.CONTENT_LENGTH] = str(size) | |||
| if hdrs.CONTENT_LENGTH not in skip_auto_headers: | |||
| self.headers[hdrs.CONTENT_LENGTH] = str(size) | |||
There was a problem hiding this comment.
This one looks wrong. If we don't set content length here, we should fallback to chunked = True mode. Otherwise we'll violate the spec.
There was a problem hiding this comment.
whoa Yep you're right, I'll fix this right away
Even when the caller asked to skip it!
|
also fixes #457 |
asvetlov
added a commit
that referenced
this pull request
Sep 14, 2015
…ader Skip auto-generation of Content-Type header.
|
Merged. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-Type header automatic generation did not honor
the documented
skip_auto_headersparam.With this patch we correctly skip generation of this header
while documenting that it is not possible to do so for the
Content-Lengthheader.See Issue #379 for details.