Add separate non-blocking start_app corountine #5391
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This will add a separate start corountine allowing the user to use a similar half-performant function as
run_app
but if they wish to do the keepalive sleeps themselves.Are there changes in behavior for the user?
This has 0 breaking changes, unless someone depends on the previous
_run_app
function which was renamed tostat_app
and had the keepalive code moved.Related issue number
This should close #5386, which I opened confused about the pre-commit hooks failing.
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.If there is for
run_app
then I guess? I did not add any new unit tests for the newstart_app
function.I do not want to reveal my real name, looking at the document it doesn't seem as if any aliases are there so I am not gonna add myself there. Which is completely fine by me.
Not possible considering
run_app
is dependent onstart_app
which means an exception to that rule is made here.