Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content-type on empty string. #5393

Merged
merged 12 commits into from
Oct 24, 2021
Merged

Fix content-type on empty string. #5393

merged 12 commits into from
Oct 24, 2021

Conversation

Dreamsorcerer
Copy link
Member

Fixes #5392

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 10, 2021
@codecov
Copy link

codecov bot commented Jan 10, 2021 •
edited
Loading

Codecov Report

Merging #5393 (37150d4) into master (c091db8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5393      +/-   ##
==========================================
- Coverage   93.33%   93.33%   -0.01%     
==========================================
  Files         102      102              
  Lines       30066    30080      +14     
  Branches     2689     2683       -6     
==========================================
+ Hits        28063    28074      +11     
- Misses       1828     1832       +4     
+ Partials      175      174       -1
Flag Coverage Δ
unit 93.25% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_reqrep.py 98.01% <100.00%> (ø)
tests/test_client_functional.py 98.21% <100.00%> (+0.01%) ⬆️
tests/conftest.py 66.66% <0.00%> (-1.71%) ⬇️
aiohttp/multipart.py 96.10% <0.00%> (-0.17%) ⬇️
aiohttp/client_ws.py 21.96% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c091db8...37150d4. Read the comment docs.

@Dreamsorcerer
Copy link
Member Author

Anybody else seeing the same thing as me? Some checkes were not successful, but none of them failed. It appears to have just cancelled 6 for no apparent reason.

@Harmon758
Copy link
Member

Anybody else seeing the same thing as me? Some checkes were not successful, but none of them failed. It appears to have just cancelled 6 for no apparent reason.

They timed out after 15 minutes (#5389).

@Dreamsorcerer
Copy link
Member Author

I'm lost trying to figure out how to make a test for this.

@Dreamsorcerer Dreamsorcerer mentioned this pull request Sep 30, 2021
Merged
@asvetlov asvetlov added this to the 3.8 milestone Oct 1, 2021
asvetlov
asvetlov approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov asvetlov enabled auto-merge (squash) October 23, 2021 16:25
@asvetlov asvetlov merged commit c6eb530 into master Oct 24, 2021
@asvetlov asvetlov deleted the fix-empty-string branch October 24, 2021 07:58
@patchback
Copy link
Contributor

patchback bot commented Oct 24, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/c6eb5307aef3df6e4b4c8fa4292eaafeea265ed2/pr-5393

Backported as #6121

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 24, 2021
@Dreamsorcerer
Fix content-type on empty string. (#5393)
5df5192 
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
(cherry picked from commit c6eb530)
@patchback patchback bot mentioned this pull request Oct 24, 2021
Merged
asvetlov added a commit that referenced this pull request Oct 24, 2021
@patchback @Dreamsorcerer @asvetlov
[PR #5393/c6eb5307 backport][3.8] Fix content-type on empty string. (#…
8d66590 
…6121)

* Fix content-type on empty string. (#5393)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
(cherry picked from commit c6eb530)

* fix

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

Setting empty str as data does not set text/plain header
3 participants
@Dreamsorcerer @Harmon758 @asvetlov