Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused host and port from low-level server #586

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Conversation

asvetlov
Copy link
Member

@fafhrd91 do you remember why these params exist??

@fafhrd91
Copy link
Member

+1
I used it before we added aiohttp.web

Sent from my iPhone

On Oct 23, 2015, at 1:13 AM, Andrew Svetlov notifications@github.com wrote:

@fafhrd91 do you remember why these params exist??

You can view, comment on, or merge this pull request online at:

#586

Commit Summary

Drop unused host and port from low-level server
File Changes

M aiohttp/server.py (4)
Patch Links:

https://github.com/KeepSafe/aiohttp/pull/586.patch
https://github.com/KeepSafe/aiohttp/pull/586.diff

Reply to this email directly or view it on GitHub.

asvetlov added a commit that referenced this pull request Oct 23, 2015
Drop unused host and port from low-level server
@asvetlov asvetlov merged commit 5049d2e into master Oct 23, 2015
@asvetlov asvetlov deleted the drop_unused_params branch October 31, 2015 23:47
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants