Avoid sending cookie attributes in Cookie header #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://travis-ci.org/KeepSafe/aiohttp/jobs/88759770 Strange. Is that good idea to take cookie name from Morsel? |
|
Well, I support the idea for sending key-value pairs only. |
|
I think it's done now. Please check. |
asvetlov
added a commit
that referenced
this pull request
Dec 18, 2015
Avoid sending cookie attributes in Cookie header
|
Cool! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation sends attributes of every cookie key-value pair in Cookie HTTP header:
key=value;
httponly;
Path=/;
secure;
key=value;
httponly;
Path=/;
secure;
key=value;
httponly;
Path=/;
expires=Sun, 31-Jan-2016 11:00:00 GMT;
Domain=.example.net.;
This behaviour is wrong, you can inspect specs to see that attributes must exist only in incoming Set-Cookie header and affect only cookie storage logic in decisions whether to send particular pair or not.
https://tools.ietf.org/html/rfc6265#section-3.1