Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6134/0fef0a30 backport][3.8] Fix gunicorn signal bug #6148

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 27, 2021

This is a backport of PR #6134 as merged into master (0fef0a3).

What do these changes do?

🐛 Fix resetting SIGCHLD signals in Gunicorn aiohttp Worker to fix subprocesses that capture output having an incorrect returncode.

Are there changes in behavior for the user?

No

Related issue number

Fix #6130

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Fix resetting SIGCHLD in Gunicorn Worker

* add CONTRIBUTORS and add CHANGES

* add CONTRIBUTORS and add CHANGES

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change CHANGES spell

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update aiohttp/worker.py

* Fix line length

Co-authored-by: liuyixin <wj@liuyixindeMacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
(cherry picked from commit 0fef0a3)
@patchback patchback bot requested review from asvetlov and webknjaz as code owners October 27, 2021 17:10
@patchback patchback bot mentioned this pull request Oct 27, 2021
5 tasks
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #6148 (0fef0a3) into 3.8 (66e281f) will decrease coverage by 4.21%.
The diff coverage is 90.51%.

❗ Current head 0fef0a3 differs from pull request most recent head fc6a4b1. Consider uploading reports for the commit fc6a4b1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #6148      +/-   ##
==========================================
- Coverage   97.52%   93.31%   -4.22%     
==========================================
  Files          44      102      +58     
  Lines        8865    30200   +21335     
  Branches     1429     2706    +1277     
==========================================
+ Hits         8646    28180   +19534     
- Misses        103     1843    +1740     
- Partials      116      177      +61     
Flag Coverage Δ
unit 93.24% <90.31%> (-4.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 97.93% <ø> (-2.07%) ⬇️
aiohttp/web_log.py 100.00% <ø> (ø)
aiohttp/web_middlewares.py 100.00% <ø> (ø)
aiohttp/web_protocol.py 86.41% <ø> (-4.20%) ⬇️
aiohttp/web_request.py 95.91% <ø> (-1.65%) ⬇️
aiohttp/web_response.py 98.41% <ø> (+0.14%) ⬆️
aiohttp/web_routedef.py 98.11% <ø> (+0.01%) ⬆️
aiohttp/web_runner.py 92.34% <ø> (-5.29%) ⬇️
aiohttp/web_server.py 94.28% <ø> (-5.72%) ⬇️
aiohttp/web_urldispatcher.py 97.54% <ø> (-0.06%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed1b0f...fc6a4b1. Read the comment docs.

@asvetlov asvetlov merged commit 0b42855 into 3.8 Oct 27, 2021
@asvetlov asvetlov deleted the patchback/backports/3.8/0fef0a30797c960ab748664599fab54e6cc2d025/pr-6134 branch October 27, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants