Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the proxy.py test dep to v3.4.0 #6176

Closed
wants to merge 2 commits into from

Conversation

webknjaz
Copy link
Member

What do these changes do?

This is the version that started supporting ephemeral port as a
first-class citizen so this patch also uses that.

(Note that this is currently a draft because the recent proxy.py has a dependency conflict with us — they put a precise pin on the typing-extensions requirement; to be bumped once the upstream issue is solved)

Are there changes in behavior for the user?

No.

Related issue number

abhinavsingh/proxy.py#617

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

This is the version that started supporting ephemeral port as a
first-class citizen.
@webknjaz webknjaz added bot:chronographer:skip This PR does not need to include a change note backport-3.8 labels Oct 29, 2021
@webknjaz webknjaz marked this pull request as draft October 29, 2021 23:34
@webknjaz webknjaz added dependencies Pull requests that update a dependency file enhancement infra meta client labels Oct 29, 2021
Copy link
Member Author

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has already been implemented in another commit. Nothing to do here.

@@ -5,7 +5,7 @@ cryptography==3.3.1; platform_machine!="i686" and python_version<"3.9" # no 32-b
freezegun==1.1.0
mypy==0.910; implementation_name=="cpython"
mypy-extensions==0.4.3; implementation_name=="cpython"
proxy.py==2.3.1
proxy.py==3.4.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was supposed to be v2.4.0 but it's already proxy.py ~= 2.4.4rc3.

@webknjaz webknjaz closed this Sep 20, 2022
@webknjaz webknjaz deleted the testing/proxy.py-3.4.0-plus branch September 21, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note client dependencies Pull requests that update a dependency file enhancement infra meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant