Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON media type matching case insensitive #6181

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

scop
Copy link
Contributor

@scop scop commented Oct 31, 2021

What do these changes do?

Per RFC 2045, section 2 and appendix A, make JSON media type matching case insensitive.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@scop scop requested a review from asvetlov as a code owner October 31, 2021 06:24
Per RFC 2045, section 2 and appendix A.
@scop scop force-pushed the case-insensitive-json branch from 4e91b7e to c4a3b9d Compare October 31, 2021 06:25
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 31, 2021
@scop
Copy link
Contributor Author

scop commented Oct 31, 2021

Note that this will conflict with #6180, will fix the other after one of these is merged.

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #6181 (c4a3b9d) into master (9c7f3d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6181   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files         102      102           
  Lines       30325    30329    +4     
  Branches     2724     2724           
=======================================
+ Hits        28299    28303    +4     
  Misses       1849     1849           
  Partials      177      177           
Flag Coverage Δ
unit 93.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/helpers.py 96.92% <100.00%> (ø)
tests/test_helpers.py 98.88% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7f3d3...c4a3b9d. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asvetlov asvetlov merged commit 15adfbc into aio-libs:master Oct 31, 2021
@scop scop deleted the case-insensitive-json branch November 1, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants