Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6451/a60e8a58 forwardport][3.9] Regression test for handling unsupported Upgrade requests (issue #6446) #6456

Conversation

webknjaz
Copy link
Member

This is a forwardport of PR #6451 as merged into 3.8 (a60e8a5).

Co-authored-by: Sviatoslav Sydorenko webknjaz@redhat.com
(cherry picked from commit a60e8a5)

What do these changes do?

aiohttp server test for handling client requests with unsupported Upgrade headers (issue #6446).

…libs#6446) (aio-libs#6451)

Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
(cherry picked from commit a60e8a5)
@webknjaz webknjaz added the bot:chronographer:skip This PR does not need to include a change note label Dec 23, 2021
@webknjaz webknjaz requested a review from asvetlov as a code owner December 23, 2021 15:07
@webknjaz webknjaz enabled auto-merge (squash) December 23, 2021 15:07
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #6456 (70f45e9) into master (eda8114) will increase coverage by 0.01%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6456      +/-   ##
==========================================
+ Coverage   93.35%   93.36%   +0.01%     
==========================================
  Files         104      104              
  Lines       30484    30496      +12     
  Branches     3067     3067              
==========================================
+ Hits        28457    28472      +15     
  Misses       1850     1850              
+ Partials      177      174       -3     
Flag Coverage Δ
unit 93.28% <76.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_web_server.py 97.60% <76.92%> (-2.41%) ⬇️
aiohttp/web_protocol.py 88.31% <0.00%> (+1.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda8114...70f45e9. Read the comment docs.

@webknjaz webknjaz merged commit 7f3cb1a into aio-libs:master Dec 28, 2021
@webknjaz webknjaz deleted the patchback/backports/master/a60e8a581e3c1987060533a69130ae026cbf6c90/pr-6451 branch April 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants