-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path web app run #6842
Add path web app run #6842
Conversation
Need to see a test covering this. Could probably just remove |
Okay i remove str() for this two test and all test in this file passed |
Also, test failing. Looks like there's another place that needs a |
@Dreamsorcerer For me all test passed or skipped because i working on ubuntu (WSL) |
This pull request introduces 1 alert when merging 6391e9e into 934db9a - view on LGTM.com new alerts:
|
We run a lot of tests in CI, so check the output. You should be able to reproduce the mypy errors on your machine, by simply running |
This reverts commit e4fcb74.
What do these changes do?
I modify the web.py file and add Union[str,pathlib.Path] for path
Are there changes in behavior for the user?
For the option of path, we can have str or pathlib.path
Related issue number
#6839
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.