Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patchback/backports/3.9/f90cb1952c272936845b93a8f424b32e703d545c/pr 6843 #6844

Closed
wants to merge 2 commits into from
Closed

Patchback/backports/3.9/f90cb1952c272936845b93a8f424b32e703d545c/pr 6843 #6844

wants to merge 2 commits into from

Conversation

SamirPS
Copy link
Contributor

@SamirPS SamirPS commented Jul 24, 2022

What do these changes do?

I modify the web.py file and add Union[str,pathlib.Path] for path

Are there changes in behavior for the user?

For the option of path, we can have str or pathlib.path

Related issue number

#6839

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 24, 2022
@Dreamsorcerer Dreamsorcerer changed the base branch from master to 3.9 July 24, 2022 14:28
@Dreamsorcerer
Copy link
Member

Think you might have messed up the conflicts, this appears to only include the test changes and nothing else.

@SamirPS
Copy link
Contributor Author

SamirPS commented Jul 24, 2022

weird i will check the 28 july

@SamirPS SamirPS closed this Jul 26, 2022
@SamirPS SamirPS deleted the patchback/backports/3.9/f90cb1952c272936845b93a8f424b32e703d545c/pr-6843 branch July 26, 2022 21:58
@SamirPS
Copy link
Contributor Author

SamirPS commented Jul 26, 2022

I delete the branch and redo the things you tell me @Dreamsorcerer i didn't know it's will close the pull requests

@SamirPS
Copy link
Contributor Author

SamirPS commented Aug 1, 2022

@Dreamsorcerer ??

@Dreamsorcerer
Copy link
Member

Did you create a new PR? You can just repush your local branch.

@SamirPS
Copy link
Contributor Author

SamirPS commented Aug 2, 2022

The branch : Patchback/backports/3.9/f90cb1952c272936845b93a8f424b32e703d545c/pr-6843 exist on my github

@webknjaz
Copy link
Member

webknjaz commented Aug 2, 2022

Try opening a PR with that branch then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants