Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7055/7d1ada8a backport][3.9] Add auto_decompress parameter to ClientSession.request() #7091

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 20, 2022

This is a backport of PR #7055 as merged into master (7d1ada8).

What do these changes do?

Added a parameter to ClientSession.request() method to override the ClientSession.auto_decompress attribute.

Implements changes proposed in

Are there changes in behavior for the user?

As discussed in #3751, the user is now able to enable/disable auto_decompress on a per-request basis.

Related issue number

#3751

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

## What do these changes do?

Added a parameter to `ClientSession.request()` method to override the
`ClientSession.auto_decompress` attribute.

Implements changes proposed in

## Are there changes in behavior for the user?

As discussed in #3751, the user is now able to enable/disable
`auto_decompress` on a per-request basis.

## Related issue number

#3751

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [x] Add a new news fragment into the `CHANGES` folder
  * name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
  * ensure type is one of the following:
    * `.feature`: Signifying a new feature.
    * `.bugfix`: Signifying a bug fix.
    * `.doc`: Signifying a documentation improvement.
    * `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
(cherry picked from commit 7d1ada8)
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #7091 (60894b4) into 3.9 (2670a39) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.9    #7091   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         103      103           
  Lines       30226    30226           
  Branches     3756     3756           
=======================================
  Hits        29415    29415           
  Misses        617      617           
  Partials      194      194           
Flag Coverage Δ
CI-GHA 97.21% <ø> (ø)
OS-Linux 96.87% <ø> (ø)
OS-Windows 94.37% <ø> (+<0.01%) ⬆️
OS-macOS 96.48% <ø> (ø)
Py-3.10.8 96.91% <ø> (-0.05%) ⬇️
Py-3.11.0 96.33% <ø> (ø)
Py-3.7.15 96.73% <ø> (+0.05%) ⬆️
Py-3.7.9 94.22% <ø> (ø)
Py-3.8.10 94.15% <ø> (+<0.01%) ⬆️
Py-3.8.14 96.58% <ø> (ø)
Py-3.9.13 94.15% <ø> (ø)
Py-3.9.14 96.38% <ø> (ø)
Py-3.9.15 96.57% <ø> (-0.05%) ⬇️
Py-pypy7.3.9 96.22% <ø> (ø)
VM-macos 96.48% <ø> (ø)
VM-ubuntu 96.87% <ø> (ø)
VM-windows 94.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit a9c86b1 into 3.9 Nov 20, 2022
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/7d1ada8ae598c61dcb087516358db3803ae105a6/pr-7055 branch November 20, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants