Enable use of await
for a class based view
#714
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you implement a middleware in the 3.5 syntax (native coroutines, e.g.
async def
andawait
) for class based views, they will yield aTypeError
saying that thatweb.View is not awaitable
. This is due to a new magic method__await__
for classes that needs to be implemented. This change simply uses the current__iter__
behavior (supporting 3.4@asyncio.coroutine
andyield from
) and enables the 3.5await
keyword (required for native coroutines, e.g.async def
)A quick example of an error this can cause is in middleware written in the 3.5 syntax:
Without the
__await__
method implemented aTypeError
is raised.Validated to work with 3.4+